Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demangle function names in Rust compilation tests comparison #46

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

greenhat
Copy link
Contributor

Close #41

The function names in both the .mir and .wat files are demangled in tests before expect! comparison. This makes tests stable when the Rust toolchain version changes and more readable.

The function names in both the .mir and .wat files are demangled in tests
before `expect!` comparison. This makes tests stable when rust toolchain
version changes and more readable.
@greenhat greenhat requested a review from a team October 23, 2023 10:02
Copy link
Contributor

@bitwalker bitwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bitwalker bitwalker merged commit 5e8d197 into main Oct 23, 2023
1 check passed
@bitwalker bitwalker deleted the greenhat/mangled-hash-i41 branch October 23, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option in Wasm frontend to remove hash in mangled function names (for golden tests)
2 participants